MarcosZyk commented on code in PR #11681:
URL: https://github.com/apache/iotdb/pull/11681#discussion_r1426338393
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/filter/DeviceFilterVisitor.java:
##########
@@ -38,4 +40,26 @@ public boolean visitPathContainsFilter(
}
return
info.getFullPath().toLowerCase().contains(pathContainsFilter.getContainString());
}
+
+ @Override
+ public boolean visitTemplateFilter(TemplateFilter templateFilter,
IDeviceSchemaInfo info) {
+ if (templateFilter.getTemplateName() == null) {
+ return true;
+ }
+ String TemplateName = "null";
Review Comment:
Use static variables.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/utils/filter/DeviceFilterVisitor.java:
##########
@@ -38,4 +40,26 @@ public boolean visitPathContainsFilter(
}
return
info.getFullPath().toLowerCase().contains(pathContainsFilter.getContainString());
}
+
+ @Override
+ public boolean visitTemplateFilter(TemplateFilter templateFilter,
IDeviceSchemaInfo info) {
+ if (templateFilter.getTemplateName() == null) {
+ return true;
+ }
+ String TemplateName = "null";
+ boolean EqualAns;
Review Comment:
stay with camel style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
