Caideyipi commented on code in PR #12275:
URL: https://github.com/apache/iotdb/pull/12275#discussion_r1549678446
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionPullConsumer.java:
##########
@@ -65,26 +66,29 @@ public
SubscriptionPullConsumer(SubscriptionPullConsumer.Builder builder) {
super(builder);
this.autoCommit = builder.autoCommit;
- this.autoCommitInterval = builder.autoCommitInterval;
+ this.autoCommitIntervalMs = builder.autoCommitIntervalMs;
}
- public SubscriptionPullConsumer(Properties config) {
+ public SubscriptionPullConsumer(Properties properties) {
this(
- config,
+ properties,
(Boolean)
- config.getOrDefault(
+ properties.getOrDefault(
ConsumerConstant.AUTO_COMMIT_KEY,
ConsumerConstant.AUTO_COMMIT_DEFAULT_VALUE),
(Integer)
- config.getOrDefault(
- ConsumerConstant.AUTO_COMMIT_INTERVAL_KEY,
- ConsumerConstant.AUTO_COMMIT_INTERVAL_DEFAULT_VALUE));
+ properties.getOrDefault(
Review Comment:
I noticed that some of the "ms"s are with the datatype of "long", but some
with "int". Are there any reasons to apply "int" as the data type? Maybe in
pipe module we often use "long" when we encountered a "ms" value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
