VGalaxies commented on code in PR #12275:
URL: https://github.com/apache/iotdb/pull/12275#discussion_r1549687475
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/SubscriptionPullConsumer.java:
##########
@@ -65,26 +66,29 @@ public
SubscriptionPullConsumer(SubscriptionPullConsumer.Builder builder) {
super(builder);
this.autoCommit = builder.autoCommit;
- this.autoCommitInterval = builder.autoCommitInterval;
+ this.autoCommitIntervalMs = builder.autoCommitIntervalMs;
}
- public SubscriptionPullConsumer(Properties config) {
+ public SubscriptionPullConsumer(Properties properties) {
this(
- config,
+ properties,
(Boolean)
- config.getOrDefault(
+ properties.getOrDefault(
ConsumerConstant.AUTO_COMMIT_KEY,
ConsumerConstant.AUTO_COMMIT_DEFAULT_VALUE),
(Integer)
- config.getOrDefault(
- ConsumerConstant.AUTO_COMMIT_INTERVAL_KEY,
- ConsumerConstant.AUTO_COMMIT_INTERVAL_DEFAULT_VALUE));
+ properties.getOrDefault(
Review Comment:
no essential difference between using int and long here... it has been
changed to "long" to unify with pipe module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
