MarcosZyk commented on code in PR #12327:
URL: https://github.com/apache/iotdb/pull/12327#discussion_r1562577795
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ConfigMTree.java:
##########
@@ -621,6 +628,81 @@ private IConfigMNode getNodeSetTemplate(int templateId,
PartialPath path)
// endregion
+ // region table management
+
+ public synchronized void preCreateTable(PartialPath database, TsTable table)
Review Comment:
Removed.
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -1039,6 +1044,80 @@ public Map<String, TDatabaseSchema>
getMatchedDatabaseSchemasByOneName(
return schemaMap;
}
+ // region table management
+
+ public TSStatus preCreateTable(PreCreateTablePlan preCreateTablePlan) {
+ databaseReadWriteLock.writeLock().lock();
+ try {
+ mTree.preCreateTable(
+ new PartialPath(new String[] {ROOT,
preCreateTablePlan.getDatabase()}),
+ preCreateTablePlan.getTable());
+ return RpcUtils.SUCCESS_STATUS;
+ } catch (MetadataException e) {
+ return RpcUtils.getStatus(e.getErrorCode(), e.getMessage());
+ } finally {
+ databaseReadWriteLock.writeLock().unlock();
+ }
+ }
+
+ public TSStatus rollbackCreateTable(RollbackCreateTablePlan
rollbackCreateTablePlan) {
+ databaseReadWriteLock.writeLock().lock();
+ try {
+ mTree.rollbackCreateTable(
+ new PartialPath(new String[] {ROOT,
rollbackCreateTablePlan.getDatabase()}),
+ rollbackCreateTablePlan.getTableName());
+ return RpcUtils.SUCCESS_STATUS;
+ } catch (MetadataException e) {
+ return RpcUtils.getStatus(e.getErrorCode(), e.getMessage());
+ } finally {
+ databaseReadWriteLock.writeLock().unlock();
+ }
+ }
+
+ public TSStatus commitCreateTable(CommitCreateTablePlan
commitCreateTablePlan) {
+ databaseReadWriteLock.writeLock().lock();
+ try {
+ mTree.commitCreateTable(
+ new PartialPath(new String[] {ROOT,
commitCreateTablePlan.getDatabase()}),
+ commitCreateTablePlan.getTableName());
+ return RpcUtils.SUCCESS_STATUS;
+ } catch (MetadataException e) {
+ return RpcUtils.getStatus(e.getErrorCode(), e.getMessage());
+ } finally {
+ databaseReadWriteLock.writeLock().unlock();
+ }
+ }
+
+ public void getTable() {}
+
+ public void getAllTables() {}
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
