lancelly commented on code in PR #12393:
URL: https://github.com/apache/iotdb/pull/12393#discussion_r1592314017
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/OperatorTreeGenerator.java:
##########
@@ -2947,6 +2949,18 @@ public List<Operator>
dealWithConsumeAllChildrenPipelineBreaker(
for (PlanNode localChild : node.getChildren()) {
Operator childOperation = localChild.accept(this, context);
parentPipelineChildren.add(childOperation);
+ // if we don't create extra pipeline, the root of the child pipeline
should be current root
+ // for example, we have IdentitySinkNode -> DeviceViewNode ->
[ScanNode, ScanNode, ScanNode]
+ // the parent of the pipeline of ScanNode should be IdentitySinkNode
in the map, otherwise
+ // we will lose the information of these pipelines
+ List<PipelineMemoryEstimator> childPipelineMemoryEstimators =
+
context.getParentPlanNodeIdToMemoryEstimator().get(localChild.getPlanNodeId());
+ if (childPipelineMemoryEstimators != null) {
+
context.getParentPlanNodeIdToMemoryEstimator().remove(localChild.getPlanNodeId());
+ context
+ .getParentPlanNodeIdToMemoryEstimator()
+ .put(node.getPlanNodeId(), childPipelineMemoryEstimators);
+ }
Review Comment:
I updated the comment.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/LastCacheScanOperator.java:
##########
@@ -83,4 +87,11 @@ public long calculateRetainedSizeAfterCallingNext() {
public PlanNodeId getSourceId() {
return sourceId;
}
+
+ @Override
+ public long getEstimatedMemoryUsageInBytes() {
+ return INSTANCE_SIZE
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
