lancelly commented on code in PR #12393:
URL: https://github.com/apache/iotdb/pull/12393#discussion_r1592315583


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/UpdateLastCacheOperator.java:
##########
@@ -89,4 +94,14 @@ protected void appendLastValueToTsBlockBuilder(long 
lastTime, TsPrimitiveType la
     LastQueryUtil.appendLastValue(
         tsBlockBuilder, lastTime, fullPath.getFullPath(), 
lastValue.getStringValue(), dataType);
   }
+
+  @Override
+  public long getEstimatedMemoryUsageInBytes() {
+    return INSTANCE_SIZE

Review Comment:
   Now I refactored EstimatedSizeOfPartialPathWithoutClassSize to 
EstimatedSizeOfPartialPath in which the INSTANCE_SIZE of PartialPath is 
calculated. I removed INSTANCE_SIZE of PartialPath in other classes.



##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/LastQueryTransformOperator.java:
##########
@@ -117,4 +122,13 @@ public void close() throws Exception {
     }
     tsBlockBuilder = null;
   }
+
+  @Override
+  public long getEstimatedMemoryUsageInBytes() {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to