Caideyipi commented on code in PR #12476:
URL: https://github.com/apache/iotdb/pull/12476#discussion_r1617517347
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java:
##########
@@ -221,7 +222,7 @@ public class IoTDBConfig {
private int walBufferQueueCapacity = 500;
/** Size threshold of each wal file. Unit: byte */
- private volatile long walFileSizeThresholdInByte = 30 * 1024 * 1024L;
+ private volatile long walFileSizeThresholdInByte = 30 * 1024L * 1024L;
Review Comment:
Why change this here?
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -763,6 +763,10 @@ data_replication_factor=1
# Datatype: long
# iot_consensus_cache_window_time_in_ms=-1
+# WAL compression algorithm
+# options: UNCOMPRESSED, SNAPPY, LZ4, GZIP, ZSTD
+# wal_compress_algorithm=UNCOMPRESSED
Review Comment:
May tune to decide the default value.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/LogWriter.java:
##########
@@ -79,6 +132,10 @@ public long size() {
return size;
}
+ public long oiginalSize() {
Review Comment:
May be replaced with originalSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
