jt2594838 commented on code in PR #12476:
URL: https://github.com/apache/iotdb/pull/12476#discussion_r1625218082
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/AbstractNodeAllocationStrategy.java:
##########
@@ -75,6 +76,9 @@ protected IWALNode createWALNode(String identifier, String
folder) {
} catch (FileNotFoundException e) {
logger.error("Fail to create wal node", e);
return WALFakeNode.getFailureInstance(e);
+ } catch (IOException e) {
+ logger.error("Meet exception when creating wal node", e);
+ return WALFakeNode.getFailureInstance(e);
}
Review Comment:
Not asking why IOException is added.
I mean that the two exception branches are effectively the same, and they
would better be merged into one to reduce redundant code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
