THUMarkLau commented on code in PR #12476:
URL: https://github.com/apache/iotdb/pull/12476#discussion_r1632194858
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/io/WALByteBufReader.java:
##########
@@ -64,8 +67,12 @@ public boolean hasNext() {
public ByteBuffer next() throws IOException {
int size = sizeIterator.next();
ByteBuffer buffer = ByteBuffer.allocate(size);
Review Comment:
This suggestion is reasonable, but implementing it would require converting
the buffer from a temporary variable to a member variable. I'm not certain
whether this modification would introduce additional bugs. Given that this is
part of the original design and unrelated to the current task, I will not
modify this section of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
