OneSizeFitsQuorum commented on code in PR #12476:
URL: https://github.com/apache/iotdb/pull/12476#discussion_r1634121432
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/AbstractNodeAllocationStrategy.java:
##########
@@ -85,6 +86,9 @@ protected IWALNode createWALNode(
} catch (FileNotFoundException e) {
logger.error("Fail to create wal node", e);
return WALFakeNode.getFailureInstance(e);
+ } catch (IOException e) {
Review Comment:
Exception handling should be the same as above
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties:
##########
@@ -1215,6 +1215,10 @@ data_replication_factor=1
# Datatype: long
# iot_consensus_cache_window_time_in_ms=-1
+# Enable Write Ahead Log compression.
+# Option: true, false
+# enable_wal_compression=false
Review Comment:
enable hot reload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
