Caideyipi commented on code in PR #14360:
URL: https://github.com/apache/iotdb/pull/14360#discussion_r1875978563
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -960,17 +904,15 @@ public TSStatus migrateRegion(TMigrateRegionReq
migrateRegionReq) {
*/
public TSStatus createRegionGroups(
TConsensusGroupType consensusGroupType, CreateRegionGroupsPlan
createRegionGroupsPlan) {
- final long procedureId =
- executor.submitProcedure(
- new CreateRegionGroupsProcedure(consensusGroupType,
createRegionGroupsPlan));
- final List<TSStatus> statusList = new ArrayList<>();
- final boolean isSucceed =
- waitingProcedureFinished(Collections.singletonList(procedureId),
statusList);
- if (isSucceed) {
- return RpcUtils.SUCCESS_STATUS;
+ CreateRegionGroupsProcedure procedure =
+ new CreateRegionGroupsProcedure(consensusGroupType,
createRegionGroupsPlan);
+ executor.submitProcedure(procedure);
+ TSStatus status = waitingProcedureFinished(procedure);
+ if (status.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
+ return status;
} else {
- return new TSStatus(TSStatusCode.CREATE_REGION_ERROR.getStatusCode())
- .setMessage(statusList.get(0).getMessage());
+ return new TSStatus(TSStatusCode.CREATE_TRIGGER_ERROR.getStatusCode())
Review Comment:
Maybe create_region_error?
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -1017,25 +951,15 @@ && new
UpdateProcedurePlan(createTriggerProcedure).getSerializedSize() > planSiz
* {@link TSStatusCode#DROP_TRIGGER_ERROR} otherwise
*/
public TSStatus dropTrigger(String triggerName, boolean isGeneratedByPipe) {
- long procedureId =
- executor.submitProcedure(new DropTriggerProcedure(triggerName,
isGeneratedByPipe));
- final List<TSStatus> statusList = new ArrayList<>();
- final boolean isSucceed =
- waitingProcedureFinished(Collections.singletonList(procedureId),
statusList);
- if (isSucceed) {
- return RpcUtils.SUCCESS_STATUS;
- } else {
- return new TSStatus(TSStatusCode.DROP_TRIGGER_ERROR.getStatusCode())
Review Comment:
Seemingly in functions like this, the return status for failure may change..
This may affect IT and Cli/workbench.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
