OneSizeFitsQuorum commented on code in PR #14360:
URL: https://github.com/apache/iotdb/pull/14360#discussion_r1877708296
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -1017,25 +951,15 @@ && new
UpdateProcedurePlan(createTriggerProcedure).getSerializedSize() > planSiz
* {@link TSStatusCode#DROP_TRIGGER_ERROR} otherwise
*/
public TSStatus dropTrigger(String triggerName, boolean isGeneratedByPipe) {
- long procedureId =
- executor.submitProcedure(new DropTriggerProcedure(triggerName,
isGeneratedByPipe));
- final List<TSStatus> statusList = new ArrayList<>();
- final boolean isSucceed =
- waitingProcedureFinished(Collections.singletonList(procedureId),
statusList);
- if (isSucceed) {
- return RpcUtils.SUCCESS_STATUS;
- } else {
- return new TSStatus(TSStatusCode.DROP_TRIGGER_ERROR.getStatusCode())
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
