jt2594838 commented on code in PR #14491:
URL: https://github.com/apache/iotdb/pull/14491#discussion_r1896477912
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/SingleSeriesCompactionExecutor.java:
##########
@@ -158,8 +161,10 @@ public void execute() throws IOException {
flushChunkWriter();
}
fileWriter.checkMetadataSizeAndMayFlush();
- targetResource.updateStartTime(device, minStartTimestamp);
- targetResource.updateEndTime(device, maxEndTimestamp);
+ if (minStartTimestampSet) {
Review Comment:
You mean still let the initial value of `minStartTimestamp` be `Long.MAX`
and `maxEndTimestamp` be `Long.MIN`?
It is possible, but I think it may be more important not to leave the
impression that Long.MAX and Long.MIN are treated as special timestamps and
keep the consistency with other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
