shuwenwei commented on code in PR #14491:
URL: https://github.com/apache/iotdb/pull/14491#discussion_r1896613725
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/estimator/AbstractCompactionEstimator.java:
##########
@@ -140,8 +142,12 @@ protected int
calculatingMaxOverlapFileNumInSubCompactionTask(List<TsFileResourc
long maxEndTimeOfCurrentDevice = Long.MIN_VALUE;
int overlapFileNumOfCurrentDevice = 0;
for (ArrayDeviceTimeIndex resource : resourcesContainsCurrentDevice) {
- long deviceStartTimeInCurrentFile = resource.getStartTime(device);
- long deviceEndTimeInCurrentFile = resource.getEndTime(device);
+ if (resource.definitelyNotContains(device)) {
Review Comment:
This check should have been done in line135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
