Sh-Zh-7 commented on code in PR #14213:
URL: https://github.com/apache/iotdb/pull/14213#discussion_r1915298603
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/aggregation/SumAccumulator.java:
##########
@@ -77,6 +77,34 @@ public void addInput(Column[] arguments) {
}
}
+ @Override
+ public void removeInput(Column[] arguments) {
+ checkArgument(arguments.length == 1, "argument of Sum should be one
column");
+ switch (argumentDataType) {
+ case INT32:
+ removeIntInput(arguments[0]);
+ return;
+ case INT64:
+ removeLongInput(arguments[0]);
+ return;
+ case FLOAT:
+ removeFloatInput(arguments[0]);
+ return;
+ case DOUBLE:
+ removeDoubleInput(arguments[0]);
+ return;
+ case TEXT:
+ case BLOB:
+ case STRING:
+ case BOOLEAN:
+ case DATE:
Review Comment:
We cannot sum DATE and TIMESTAMP, thus we cannot remove them as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
