Sh-Zh-7 commented on code in PR #14213: URL: https://github.com/apache/iotdb/pull/14213#discussion_r1915345639
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/window/function/value/FirstValueFunction.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.window.function.value; + +import org.apache.iotdb.db.queryengine.execution.operator.process.window.function.WindowFunction; +import org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.Partition; + +import org.apache.tsfile.block.column.ColumnBuilder; + +public class FirstValueFunction implements WindowFunction { + private final int channel; + private final boolean ignoreNull; + + public FirstValueFunction(int channel, boolean ignoreNull) { + this.channel = channel; + this.ignoreNull = ignoreNull; + } + + @Override + public void reset() {} Review Comment: `reset` is called when encountering a new partition. These functions are stateless, so they do nothing in `reset`. I dont think we should add comments to all these empty `reset`. Perhaps a better solution is that we implement a empty `reset` in interface as default value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
