Beyyes commented on code in PR #14213: URL: https://github.com/apache/iotdb/pull/14213#discussion_r1914194492
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/window/partition/Partition.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.window.partition; + +import org.apache.tsfile.block.column.Column; +import org.apache.tsfile.block.column.ColumnBuilder; +import org.apache.tsfile.read.common.block.TsBlock; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +public class Partition { + private final List<TsBlock> tsBlocks; + private int cachedPositionCount = -1; + + public Partition(List<TsBlock> tsBlocks, int startIndexInFirstBlock, int endIndexInLastBlock) { + if (tsBlocks.size() == 1) { + int length = endIndexInLastBlock - startIndexInFirstBlock; + this.tsBlocks = + Collections.singletonList(tsBlocks.get(0).getRegion(startIndexInFirstBlock, length)); + return; + } + + this.tsBlocks = new ArrayList<>(); + // First TsBlock + TsBlock firstBlock = tsBlocks.get(0).subTsBlock(startIndexInFirstBlock); + this.tsBlocks.add(firstBlock); + // Middle TsBlock + for (int i = 1; i < tsBlocks.size() - 1; i++) { + this.tsBlocks.add(tsBlocks.get(i)); + } + // Last TsBlock + TsBlock lastBlock = tsBlocks.get(tsBlocks.size() - 1).getRegion(0, endIndexInLastBlock); + this.tsBlocks.add(lastBlock); + } + + public int getPositionCount() { + if (cachedPositionCount == -1) { + // Lazy initialized + cachedPositionCount = 0; + for (TsBlock block : tsBlocks) { + cachedPositionCount += block.getPositionCount(); + } + } + + return cachedPositionCount; + } + + public int getValueColumnCount() { + return tsBlocks.get(0).getValueColumnCount(); + } + + public TsBlock getTsBlock(int tsBlockIndex) { + return tsBlocks.get(tsBlockIndex); + } + + public List<Column[]> getAllColumns() { + List<Column[]> allColumns = new ArrayList<>(); Review Comment: ```suggestion List<Column[]> allColumns = new ArrayList<>(tsBlocks.size()); ``` ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/window/partition/frame/RangeFrame.java: ########## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame; + +import org.apache.iotdb.db.queryengine.execution.operator.process.window.exception.FrameTypeException; +import org.apache.iotdb.db.queryengine.execution.operator.process.window.utils.ColumnList; +import org.apache.iotdb.db.queryengine.execution.operator.process.window.utils.Range; +import org.apache.iotdb.db.queryengine.execution.operator.process.window.utils.RowComparator; + +import org.apache.tsfile.enums.TSDataType; +import org.apache.tsfile.write.UnSupportedDataTypeException; + +import java.util.List; + +import static org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame.FrameInfo.FrameBoundType.CURRENT_ROW; +import static org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame.FrameInfo.FrameBoundType.FOLLOWING; +import static org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame.FrameInfo.FrameBoundType.PRECEDING; +import static org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame.FrameInfo.FrameBoundType.UNBOUNDED_FOLLOWING; +import static org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame.FrameInfo.FrameBoundType.UNBOUNDED_PRECEDING; + +public class RangeFrame implements Frame { + private final FrameInfo frameInfo; + private final ColumnList column; + private final TSDataType dataType; + + private final int partitionStart; + private final int partitionEnd; + private final int partitionSize; + private final RowComparator peerGroupComparator; + private Range recentRange; + + public RangeFrame( + FrameInfo frameInfo, + int partitionStart, + int partitionEnd, + List<ColumnList> columns, + RowComparator comparator) { + this.frameInfo = frameInfo; + // Only one sort key is allowed in range frame + assert columns.size() == 1; Review Comment: Use checkArgument ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/window/partition/frame/FrameInfo.java: ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame; + +import org.apache.iotdb.db.queryengine.plan.relational.planner.SortOrder; + +public class FrameInfo { + public enum FrameType { + RANGE, + ROWS, + GROUPS + } + + public enum FrameBoundType { + UNBOUNDED_PRECEDING, + PRECEDING, + CURRENT_ROW, + FOLLOWING, + UNBOUNDED_FOLLOWING; + } + + private final FrameType frameType; + private final FrameBoundType startType; + // By convention, if a value can be an integer or a floating point + // Then it is stored in double + private final double startOffset; // For PRECEDING and FOLLOWING use + private final FrameBoundType endType; + private final double endOffset; // Same as startOffset Review Comment: I see all types of xxxOffset are int, if it's needed to use double? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
