Sh-Zh-7 commented on code in PR #14213: URL: https://github.com/apache/iotdb/pull/14213#discussion_r1923885467
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/window/partition/frame/FrameInfo.java: ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.window.partition.frame; + +import org.apache.iotdb.db.queryengine.plan.relational.planner.SortOrder; + +public class FrameInfo { + public enum FrameType { + RANGE, + ROWS, + GROUPS + } + + public enum FrameBoundType { + UNBOUNDED_PRECEDING, + PRECEDING, + CURRENT_ROW, + FOLLOWING, + UNBOUNDED_FOLLOWING; + } + + private final FrameType frameType; + private final FrameBoundType startType; + // By convention, if a value can be an integer or a floating point + // Then it is stored in double + private final double startOffset; // For PRECEDING and FOLLOWING use + private final FrameBoundType endType; + private final double endOffset; // Same as startOffset Review Comment: RangeFrame may have offset with decimal, it cannot be stored by int type. And the `FrameInfo` instances count is equal to the number of frame clause in user's SQL, so it wont cause too much extra memory footprint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
