jt2594838 commented on code in PR #15600:
URL: https://github.com/apache/iotdb/pull/15600#discussion_r2113050000
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java:
##########
@@ -426,6 +435,58 @@ private void flushDataRegionAllTsFiles() {
}
}
+ /**
+ * IoTV2 will only resend event that contains un-replicated local write
data. So we only extract
+ * ProgressIndex containing local writes for comparison to prevent
misjudgment on whether
+ * high-level tsFiles with mixed progressIndexes need to be retransmitted
+ *
+ * @return recoverProgressIndex dedicated in local DataNodeId or origin for
fallback.
+ */
+ private ProgressIndex tryToExtractLocalProgressIndexForIoTV2(ProgressIndex
origin) {
+ // There are only 2 cases:
+ // 1. origin is RecoverProgressIndex
+ if (origin instanceof RecoverProgressIndex) {
+ RecoverProgressIndex toBeTransformed = (RecoverProgressIndex) origin;
+ return new RecoverProgressIndex(
+ toBeTransformed.getDataNodeId2LocalIndex().entrySet().stream()
+ .filter(
+ entry ->
+ entry
+ .getKey()
+
.equals(IoTDBDescriptor.getInstance().getConfig().getDataNodeId()))
+ .collect(Collectors.toMap(Map.Entry::getKey,
Map.Entry::getValue)));
+ }
+ // 2. origin is HybridProgressIndex
+ else if (origin instanceof HybridProgressIndex) {
+ HybridProgressIndex toBeTransformed = (HybridProgressIndex) origin;
+ // if hybridProgressIndex contains recoverProgressIndex, which is what
we expected.
+ if (toBeTransformed
+ .getType2Index()
+ .containsKey(ProgressIndexType.RECOVER_PROGRESS_INDEX.getType())) {
+ // 2.1. transform recoverProgressIndex
+ RecoverProgressIndex specificToBeTransformed =
+ (RecoverProgressIndex)
+ toBeTransformed
+ .getType2Index()
+ .get(ProgressIndexType.RECOVER_PROGRESS_INDEX.getType());
+ return new RecoverProgressIndex(
+
specificToBeTransformed.getDataNodeId2LocalIndex().entrySet().stream()
+ .filter(
+ entry ->
+ entry
+ .getKey()
+
.equals(IoTDBDescriptor.getInstance().getConfig().getDataNodeId()))
+ .collect(Collectors.toMap(Map.Entry::getKey,
Map.Entry::getValue)));
+ }
+ // if hybridProgressIndex doesn't contain recoverProgressIndex, which is
not what we expected,
+ // fallback.
+ return origin;
+ } else {
+ // fallback
+ return origin;
Review Comment:
Print some WARN logs when the expected event occurs?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java:
##########
Review Comment:
While judging from the Pipe name works, it may make everything easier if we
use another Extractor inherited from this one. (Or even a much simpler one)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
