Pengzna commented on code in PR #15600: URL: https://github.com/apache/iotdb/pull/15600#discussion_r2113365344
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ########## Review Comment: from the view of design, pipe and IoTV2 use the same core atomic ability of plugin. So we share this class among pipe and IoTV2. I think use another Extractor inherited from this one may have low ROI, which means some dirty work to fit the existed code base and limited gain. So maybe now is enough. ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/historical/PipeHistoricalDataRegionTsFileAndDeletionExtractor.java: ########## Review Comment: from the view of design, pipe and IoTV2 use the same core atomic ability of plugin. So we share this class among pipe and IoTV2. I think using another Extractor inherited from this one may have low ROI, which means some dirty work to fit the existed code base and limited gain. So maybe now is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
