Eliaaazzz commented on PR #17386:
URL: https://github.com/apache/iotdb/pull/17386#issuecomment-4178079833
> Hi Elia, this is your first PR (pull request) for Apache IoTDB repository,
our community highly appreciate your contribution!
>
> Next, let us talk about this PR, the following points still need to be
improved:
>
> 1. The moment model has serveral versions, we can employ the large version.
> 2. The format of AINode should be fixed. Run `black . && isort .` under
`iotdb-core/ainode`.
> 3. The forecast IT failed, you should ensure the correctness first in your
local environment.
> 4. The modification in `constant.py` should be reverted, since we do not
support the corresponding function in current version.
Thank you for the review and for the warm welcome!
▎ Addressing each point:
▎ 1. The current code already uses AutonLab/MOMENT-1-large — I've verified
this is consistent in model_info.py.
▎ 2. Will run black . && isort . under iotdb-core/ainode and push the
formatting fix.
▎ 3. I'll reproduce the forecast IT failure locally and fix it before the
next push.
▎ 4. The constant.py modification has been reverted in the latest commit.
▎ Will update once #2 and #3 are addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
