Eliaaazzz commented on PR #17386: URL: https://github.com/apache/iotdb/pull/17386#issuecomment-4178089007
> Hi Elia, this is your first PR (pull request) for Apache IoTDB repository, our community highly appreciate your contribution! > > Next, let us talk about this PR, the following points still need to be improved: > > 1. The moment model has serveral versions, we can employ the large version. > 2. The format of AINode should be fixed. Run `black . && isort .` under `iotdb-core/ainode`. > 3. The forecast IT failed, you should ensure the correctness first in your local environment. > 4. The modification in `constant.py` should be reverted, since we do not support the corresponding function in current version. Thanks for the review and warm welcome. I will fix these in the next update. - I will use the larger model version when multiple versions are available. - I will run `black . && isort .` under `iotdb-core/ainode` and fix the AINode formatting issues. - I will reproduce the forecast integration test failure locally and make sure it passes before pushing the next revision. - I will revert the change in `constant.py`, since that function is not supported in the current version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
