DanielWang2035 commented on code in PR #17238:
URL: https://github.com/apache/iotdb/pull/17238#discussion_r3246258630
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/receiver/SubscriptionReceiverV1.java:
##########
@@ -669,22 +700,90 @@ private TPipeSubscribeResp
handlePipeSubscribeCommitInternal(final PipeSubscribe
if (Objects.equals(successfulCommitContexts.size(),
commitContexts.size())) {
LOGGER.info(
- "Subscription: consumer {} commit (nack: {}) successfully, commit
contexts: {}",
+ "Subscription: consumer {} commit (nack: {}) successfully, summary:
{}",
consumerConfig,
nack,
- commitContexts);
+ summarizeCommitContexts(commitContexts));
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug(
+ "Subscription: consumer {} commit (nack: {}) full commit contexts:
{}",
+ consumerConfig,
+ nack,
+ commitContexts);
+ }
} else {
LOGGER.warn(
- "Subscription: consumer {} commit (nack: {}) partially successful,
commit contexts: {}, successful commit contexts: {}",
+ "Subscription: consumer {} commit (nack: {}) partially successful,
requested summary: {}, successful summary: {}",
consumerConfig,
nack,
- commitContexts,
- successfulCommitContexts);
+ summarizeCommitContexts(commitContexts),
+ summarizeCommitContexts(successfulCommitContexts));
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug(
+ "Subscription: consumer {} commit (nack: {}) full requested commit
contexts: {}, full successful commit contexts: {}",
+ consumerConfig,
+ nack,
+ commitContexts,
+ successfulCommitContexts);
+ }
}
return
PipeSubscribeCommitResp.toTPipeSubscribeResp(RpcUtils.SUCCESS_STATUS);
Review Comment:
Fixed. The commit response now separates accepted commit contexts from the
server-side durable committed progress. The client only clears pending ACKs
using accepted contexts, and only advances local committed positions using the
committed progress returned by the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
