DanielWang2035 commented on code in PR #17238:
URL: https://github.com/apache/iotdb/pull/17238#discussion_r3278706848


##########
iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java:
##########
@@ -338,14 +343,107 @@ Map<String, TopicConfig> unsubscribe(final Set<String> 
topicNames) throws Subscr
     return unsubscribeResp.getTopics();
   }
 
+  void seek(final String topicName, final short seekType, final long timestamp)
+      throws SubscriptionException {
+    final PipeSubscribeSeekReq req;
+    try {
+      req = PipeSubscribeSeekReq.toTPipeSubscribeReq(topicName, seekType, 
timestamp);
+    } catch (final IOException e) {
+      LOGGER.warn(
+          "IOException occurred when SubscriptionProvider {} serialize seek 
request for topic {}",
+          this,
+          topicName,
+          e);
+      throw new SubscriptionRuntimeNonCriticalException(e.getMessage(), e);
+    }
+    final TPipeSubscribeResp resp;
+    try {
+      resp = getSessionConnection().pipeSubscribe(req);

Review Comment:
   Removed the pipe wording from the new seek wrapper and call-site names. Kept 
generated thrift names unchanged because they belong to the existing transport 
protocol.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to