luoluoyuyu commented on code in PR #17747:
URL: https://github.com/apache/iotdb/pull/17747#discussion_r3309328390
##########
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/disk/WindowsDiskMetricsManager.java:
##########
@@ -447,46 +465,105 @@ private double clampPercentage(double value) {
}
private List<String> executePowerShell(String command) {
- List<String> result = new ArrayList<>();
- List<String> rawOutput = new ArrayList<>();
- Process process = null;
+ if (System.currentTimeMillis() < nextPowerShellRetryTime) {
Review Comment:
失败后退避期间直接 `return Collections.emptyList()`，磁盘指标会**短暂缺失**而非沿用上次值。
对监控这是可接受的（避免 error 风暴），但建议在 `handlePowerShellFailure` 的日志中保留
`nextPowerShellRetryTime`，便于运维确认是「主动退避」而非「磁盘消失」。
非阻塞，当前实现可合入。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
