luoluoyuyu commented on code in PR #17747:
URL: https://github.com/apache/iotdb/pull/17747#discussion_r3309371567
##########
iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/disk/WindowsDiskMetricsManager.java:
##########
@@ -447,46 +465,105 @@ private double clampPercentage(double value) {
}
private List<String> executePowerShell(String command) {
- List<String> result = new ArrayList<>();
- List<String> rawOutput = new ArrayList<>();
- Process process = null;
+ if (System.currentTimeMillis() < nextPowerShellRetryTime) {
Review Comment:
During backoff, returning an empty list means disk metrics are temporarily
absent rather than stale. Acceptable to stop log storms; optional improvement
is to log next retry time at WARN when entering backoff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
