VGalaxies commented on PR #17926: URL: https://github.com/apache/iotdb/pull/17926#issuecomment-4688767212
Addressed Caideyipi's review comments in `cfdf8dacc1`: 1. Made the prefetch-to-in-flight poll transition mutually exclusive with the terminate commit check by moving the transition into a synchronized helper and making `tryCommitCurrentTerminateEvent()` synchronized as well. This removes the window where a polled event is no longer in `prefetchingQueue` but not yet visible in `inFlightEvents`. 2. Updated `executePrefetch()` so a pending `currentTerminateEvent` bypasses the normal `states.shouldPrefetch()` heuristic and keeps retrying the drain/commit path directly. Validation: - `mvn spotless:apply -pl iotdb-core/datanode` - `git diff --check` - `mvn compile -pl iotdb-core/datanode` still fails with the same unrelated dependency/generated-source mismatches (`PipePeriodicalLogReducer`, relational grammar `identifier()`, `CalcMessages`, `IndexedBlockingReserveQueue`, etc.); the modified file is not reported in the compilation errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
