DaZuiZui commented on PR #17960: URL: https://github.com/apache/iotdb/pull/17960#issuecomment-4738910097
Hi @JackieTien97 , Thanks for the careful review and helpful suggestions. I have addressed the latest review comments in PR #17960. The SELECT-list LCA alias lookup now avoids rebuilding immutable snapshots for each SingleColumn, and I added regression coverage for the wide SELECT-list LCA chain, delimited alias case sensitivity, named WINDOW definitions, DISTINCT without ORDER BY, and LCA references in window frame bounds. I verified the changes with: ./mvnw spotless:apply -pl iotdb-core/datanode ./mvnw -nsu test -pl iotdb-core/datanode -Dtest=SelectAliasReuseTest Thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
