DaZuiZui commented on PR #17960: URL: https://github.com/apache/iotdb/pull/17960#issuecomment-4861924692
I reviewed the latest commit 01af2d3fee and checked how it addresses the previous LCA plan blowup issue. Specifically, I verified that the analyzer no longer deep-copies the expanded alias expression, and that the planner now reuses previous LCA projections through symbol mappings with batched projections. I also checked the new regression tests for the Cast reuse case and the deep chained-alias case. I ran: ./mvnw test -pl iotdb-core/datanode -Dtest=SelectAliasReuseTest All 40 tests passed. The performance/robustness issue I raised before looks resolved to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
