Caideyipi commented on PR #18116: URL: https://github.com/apache/iotdb/pull/18116#issuecomment-4890640582
Follow-up for the table-model CI failures: The failed `IoTDBWindowFunction2IT` / `IoTDBWindowTVF2IT` cases expose a table-model edge case: a table device can have rows whose value columns are all null, but the device/id row still needs to be persisted in TsFile metadata. My previous early return skipped encoding when the active aligned value schema list was empty, which is valid for tree model (`ignoreAllNullRows=true`) but invalid for table model (`ignoreAllNullRows=false`). I updated the guard to return only when `activeSchemaList.isEmpty() && ignoreAllNullRows`, so tree model still drops all-null/deleted aligned devices while table model still writes the time/device metadata for all-null value rows. Local validation: - `mvn spotless:check -pl iotdb-core/datanode,integration-test -P with-integration-tests` - `git diff --check` I also tried to run the affected ITs locally, but the local build is still blocked before tests by the existing `iotdb-thrift` generated-source compile issue: missing `javax.annotation` under JDK 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
