Caideyipi commented on code in PR #18106:
URL: https://github.com/apache/iotdb/pull/18106#discussion_r3533324986
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/load/LoadTsFileDispatcherImpl.java:
##########
@@ -97,36 +97,44 @@ public LoadTsFileDispatcherImpl(
this.internalServiceClientManager = internalServiceClientManager;
this.localhostIpAddr =
IoTDBDescriptor.getInstance().getConfig().getInternalAddress();
this.localhostInternalPort =
IoTDBDescriptor.getInstance().getConfig().getInternalPort();
- this.executor =
-
IoTDBThreadPoolFactory.newCachedThreadPool(LoadTsFileDispatcherImpl.class.getName());
this.isGeneratedByPipe = isGeneratedByPipe;
}
+ private synchronized ExecutorService getOrCreateExecutor() {
+ if (executor == null || executor.isShutdown()) {
+ executor =
+
IoTDBThreadPoolFactory.newCachedThreadPool(LoadTsFileDispatcherImpl.class.getName());
+ }
+ return executor;
+ }
+
public void setUuid(String uuid) {
this.uuid = uuid;
}
@Override
public Future<FragInstanceDispatchResult> dispatch(
SubPlan root, List<FragmentInstance> instances) {
- return executor.submit(
- () -> {
- for (FragmentInstance instance : instances) {
- try (SetThreadName threadName =
- new SetThreadName(
- "load-dispatcher" + "-" + instance.getId().getFullId() +
"-" + uuid)) {
- dispatchOneInstance(instance);
- } catch (FragmentInstanceDispatchException e) {
- return new FragInstanceDispatchResult(e.getFailureStatus());
- } catch (Exception t) {
-
LOGGER.warn(DataNodeQueryMessages.CANNOT_DISPATCH_FI_FOR_LOAD_OPERATION, t);
- return new FragInstanceDispatchResult(
- RpcUtils.getStatus(
- TSStatusCode.INTERNAL_SERVER_ERROR, "Unexpected errors:
" + t.getMessage()));
- }
- }
- return new FragInstanceDispatchResult(true);
- });
+ return getOrCreateExecutor()
+ .submit(
+ () -> {
+ for (FragmentInstance instance : instances) {
+ try (SetThreadName threadName =
+ new SetThreadName(
+ "load-dispatcher" + "-" + instance.getId().getFullId()
+ "-" + uuid)) {
+ dispatchOneInstance(instance);
+ } catch (FragmentInstanceDispatchException e) {
+ return new FragInstanceDispatchResult(e.getFailureStatus());
+ } catch (Exception t) {
+
LOGGER.warn(DataNodeQueryMessages.CANNOT_DISPATCH_FI_FOR_LOAD_OPERATION, t);
+ return new FragInstanceDispatchResult(
+ RpcUtils.getStatus(
+ TSStatusCode.INTERNAL_SERVER_ERROR,
+ "Unexpected errors: " + t.getMessage()));
+ }
Review Comment:
Done. Added en/zh i18n constants for the unexpected-error status message and
switched both dispatch paths to use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
