HTHou commented on code in PR #18132:
URL: https://github.com/apache/iotdb/pull/18132#discussion_r3612979770
##########
iotdb-client/isession/src/main/java/org/apache/iotdb/isession/ITableSession.java:
##########
@@ -46,6 +48,16 @@ public interface ITableSession extends AutoCloseable {
*/
void insert(Tablet tablet) throws StatementExecutionException,
IoTDBConnectionException;
+ /**
+ * Inserts multiple {@link Tablet}s into the database.
+ *
+ * @param tablets the tablets containing time-series data to be inserted.
+ * @throws StatementExecutionException if an error occurs while executing
the statement.
+ * @throws IoTDBConnectionException if there is an issue with the IoTDB
connection.
+ */
+ void insertTablets(List<Tablet> tablets)
Review Comment:
**API suggestion:** `ITableSession` already exposes the single-tablet
operation as `insert(Tablet)`. Could this new batch method be named
`insert(List<Tablet>)` as an overload, with the corresponding implementations
and call sites updated together? That would keep the table-session API
consistent while this method is still being introduced. If the distinct
`insertTablets` name is intentional to reserve room for other batch input types
under Java generic erasure, please document that rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]