Copilot commented on code in PR #18291:
URL: https://github.com/apache/iotdb/pull/18291#discussion_r3637185445
##########
scripts/tools/windows/ops/backup.bat:
##########
@@ -82,7 +88,7 @@ for /f "tokens=1,3,7 delims=: " %%i in ('netstat /ano') do (
)
)
Review Comment:
dn_rpc_port_occupied is never set to 1 after detecting the DataNode RPC
port, so the guard `if !dn_rpc_port_occupied!==0` never flips and the script
may repeatedly run :checkIfIOTDBProcess for every matching netstat row. Set the
flag after the first match to avoid redundant work and keep the intent of the
guard correct.
This issue also appears on line 91 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
