Copilot commented on code in PR #18291:
URL: https://github.com/apache/iotdb/pull/18291#discussion_r3637404888
##########
iotdb-client/service-rpc/src/test/java/org/apache/iotdb/rpc/UrlUtilsTest.java:
##########
@@ -122,6 +123,8 @@ public void testConvertIPV6AbbURL() {
public void testConvertBracketedIPV6URL() {
assertEquals(
"[D80::ABAA:0]:22227",
UrlUtils.formatTEndPointIpv4AndIpv6Url("[D80::ABAA:0]", 22227));
+ assertEquals(
+ "[D80::ABAA:0]:invalid",
UrlUtils.formatTEndPointIpv4AndIpv6Url("D80::ABAA:0", "invalid"));
Review Comment:
The second assertion in testConvertBracketedIPV6URL uses an unbracketed IPv6
host, which makes the test name misleading and reduces clarity about what
behavior is being verified. Either rename the test or keep the input bracketed
while still exercising the String-port overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
