CritasWang commented on PR #115: URL: https://github.com/apache/iotdb-extras/pull/115#issuecomment-5067945724
Both resolved — thanks. **1. Nested result set:** the fix is correct. `exactLongSum` now checks out its own pooled session in its own try-with-resources, so the re-sum never opens a second result set on the session iterating the outer aggregate, and `SumReSumContext` dropped the session field. Good that `IoTDBTableTimeseriesAggregationIT` exercises the fallback where the re-sum runs while the outer aggregate still has pending buckets — that's exactly the case the bug would have corrupted, and it's green against the real 2.0.8 container. **2. Empty entity list:** my mistake — you're right, `doFindAllKeysByEntityIds` already early-returns `List.of()` on an empty list (covered by `findAllKeysByEntityIds_emptyListReturnsEmptyAndSkipsQuery`), so the builder never sees it. No need to move the guard down; the current placement is fine. CI is fully green on 970feca (CodeQL, code-analyze java/go/ts, compile-check 8/11/17/21, dependency-check, todo-check). LGTM — ready to merge from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
