PDGGK commented on PR #115: URL: https://github.com/apache/iotdb-extras/pull/115#issuecomment-5067410737
Thanks for the careful review, @CritasWang. **1. Nested result set in `exactLongSum`** — good catch, adopted. `exactLongSum` now checks out its own session from the pool instead of reusing the one that is iterating the outer aggregate, so it never opens a second result set on that session; `SumReSumContext` no longer carries the session. This fallback path is exercised end-to-end by `IoTDBTableTimeseriesAggregationIT`: the `> 2^53` precision case re-sums the *first* of three buckets while the outer aggregate result set still has the remaining buckets pending, and it stays green against the real `apache/iotdb:2.0.8` container with the separate session. Pushed as a follow-up commit. **2. Empty entity list in `buildFindAllKeysByEntityIdsSql`** — this case is already guarded one level up: `doFindAllKeysByEntityIds` early-returns `List.of()` when `entityIds.isEmpty()`, so the SQL builder's `AND (...)` clause is never reached with an empty list. It's covered by the `findAllKeysByEntityIds_emptyListReturnsEmptyAndSkipsQuery` unit test. Happy to move the guard directly into `buildFindAllKeysByEntityIdsSql` for defense-in-depth if you'd prefer it at the builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
