Caideyipi commented on code in PR #18429:
URL: https://github.com/apache/iotdb/pull/18429#discussion_r3763612709
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java:
##########
@@ -157,7 +157,6 @@ public class IoTConsensusServerImpl {
private final ScheduledExecutorService backgroundTaskService;
private final IoTConsensusRateLimiter ioTConsensusRateLimiter =
IoTConsensusRateLimiter.getInstance();
- private IndexedConsensusRequest lastConsensusRequest;
// Subscription queues receive IndexedConsensusRequest in real-time from
write(),
// similar to LogDispatcher, enabling in-memory data delivery without
waiting for WAL flush.
Review Comment:
Restored `lastConsensusRequest` and the periodic diagnostic log in
12c1ab28c9f. I also verified the no-subscription path: after
`buildSerializedRequests()`, the dispatcher clears the original request objects
only after state-machine apply and keeps the serialized buffers for
replication; subscription-enabled writes retain the originals for realtime
delivery. Consensus memory tests pass (5/5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
