Caideyipi commented on code in PR #18429:
URL: https://github.com/apache/iotdb/pull/18429#discussion_r3763811989
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java:
##########
@@ -157,7 +157,6 @@ public class IoTConsensusServerImpl {
private final ScheduledExecutorService backgroundTaskService;
private final IoTConsensusRateLimiter ioTConsensusRateLimiter =
IoTConsensusRateLimiter.getInstance();
- private IndexedConsensusRequest lastConsensusRequest;
// Subscription queues receive IndexedConsensusRequest in real-time from
write(),
// similar to LogDispatcher, enabling in-memory data delivery without
waiting for WAL flush.
Review Comment:
Follow-up in 37aa046e73e: the subscription registry now serializes a request
before realtime queue admission, so the shared reservation includes both the
original request objects and serialized buffers. It reports whether any queue
actually accepted the request; only when none do does `LogDispatcher` release
the original objects after serialization. `lastConsensusRequest` and its
diagnostic log remain intact. Added regression coverage for the no-queue and
serialized-before-admission paths; the consensus tests pass (7/7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
