jt2594838 opened a new pull request, #18467: URL: https://github.com/apache/iotdb/pull/18467
## Description ### Problem IoTDBDescriptor initialized the DataNode memory configuration while loading iotdb-system.properties, then initialized it again with default properties whenever no external properties loader was present. The second initialization could discard configuration-derived memory settings. ### Changes - Make loadProps report whether the system configuration source was loaded. - Initialize memoryConfig with defaults only when neither the system configuration nor an external properties loader initialized it. ### Validation - mvn test -pl iotdb-core/datanode '-Dtest=IoTDBDescriptorTest,DataNodeMemoryConfigTest' -DfailIfNoTests=false - 11 tests passed; Checkstyle and Spotless passed. <hr> This PR has: - [x] been self-reviewed. - [x] added comments explaining the why and the intent of the code wherever it would not be obvious for an unfamiliar reader. <hr> ##### Key changed/added classes (or packages if there are too many classes) in this PR - org.apache.iotdb.db.conf.IoTDBDescriptor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
