jt2594838 commented on code in PR #18467:
URL: https://github.com/apache/iotdb/pull/18467#discussion_r3840689148
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java:
##########
@@ -167,8 +167,8 @@ protected IoTDBDescriptor() {
.getConfig()
.setCustomizedProperties(loader.getCustomizedProperties());
}
- // if there are no properties, we need to init memory config
- if (!hasProperties) {
+ // If no configuration source initialized the memory config, initialize it
with defaults.
+ if (!hasLoadedProperties && !hasProperties) {
Review Comment:
Thanks for pointing this out. I added two constructor-level regression
tests. One uses a real temporary iotdb-system.properties with
datanode_memory_proportion=1:1:1:1:1:5 and verifies the activated RPC buffer
budget is maxMemory / 4; the other verifies the no-configuration fallback
remains maxMemory / 20. The tests run in separate Surefire forks so the
descriptor and memory configuration statics are isolated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
