JackieTien97 commented on code in PR #18006: URL: https://github.com/apache/iotdb/pull/18006#discussion_r3858879273
########## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/relational/tvf/fft/DoubleFFT_1D.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.commons.udf.builtin.relational.tvf.fft; + +/** Computes an in-place 1D forward DFT for interleaved complex double data. */ +public final class DoubleFFT_1D { + + private final int length; + + public DoubleFFT_1D(long length) { + if (length < 1 || length > Integer.MAX_VALUE) { + throw new IllegalArgumentException("FFT length must be a positive int-sized value."); Review Comment: [P1] Internationalize the remaining FFT helper errors The constructor error here and the input-array error in `complexForward` are still hard-coded English strings, so these new exceptions bypass the EN/ZH message catalogs. Please move both messages to matching constants in the appropriate `QueryMessages` files, using the repository's `EXCEPTION_<NORMALIZED>_<HASH>` naming convention, and reference those constants here. ########## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/relational/tvf/fft/FloatFFT_1D.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.commons.udf.builtin.relational.tvf.fft; + +/** Computes an in-place 1D forward DFT for interleaved complex float data. */ +public final class FloatFFT_1D { + + private final int length; + + public FloatFFT_1D(long length) { + if (length < 1 || length > Integer.MAX_VALUE) { + throw new IllegalArgumentException("FFT length must be a positive int-sized value."); Review Comment: [P1] Internationalize the remaining FFT helper errors This helper still has the same two hard-coded English exceptions: the constructor error here and the input-array error in `complexForward`. Please route both through matching EN/ZH `QueryMessages` constants, using the repository's `EXCEPTION_<NORMALIZED>_<HASH>` naming convention, so the `with-zh-locale` build does not retain English-only FFT errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
