jt2594838 commented on code in PR #18562:
URL: https://github.com/apache/iotdb/pull/18562#discussion_r3902820943
##########
iotdb-core/metrics/ReadMe.md:
##########
@@ -63,6 +63,7 @@ Configure the metrics module through
`iotdb-system.properties`. The main options
| `dn(cn)_metric_level` | Initial metric level. | `OFF`, `CORE`, `IMPORTANT`,
`NORMAL`, `ALL` |
| `cn_metric_prometheus_reporter_port` | Prometheus HTTP port for ConfigNode.
| `9091` |
| `dn_metric_prometheus_reporter_port` | Prometheus HTTP port for DataNode. |
`9092` |
+| `prometheus_reporter_async_update` | Serve a cached Prometheus snapshot
refreshed every 15 seconds. | `true` |
Review Comment:
Exposes the new operator-facing setting in the metrics documentation and
records the default behavior.
##########
iotdb-core/metrics/interface/src/main/i18n/en/org/apache/iotdb/metrics/i18n/MetricsMessages.java:
##########
@@ -128,5 +128,6 @@ private MetricsMessages() {}
public static final String
LOG_IOTDBSESSIONREPORTER_START_WRITE_ARG_ARG_E79CDDAE = "IoTDBSessionReporter
start, write to {}:{}";
public static final String
LOG_PROMETHEUSREPORTER_STARTED_USE_PORT_ARG_A688FFC8 = "PrometheusReporter
started, use port {}";
public static final String
LOG_DETECTED_ERROR_TAKING_METRIC_TIMER_SNAPSHOT_WILL_DISCARD_METRIC_B7154169 =
"Detected an error when taking metric timer snapshot, will discard this metric";
+ public static final String
LOG_PROMETHEUSREPORTER_FAILED_TO_UPDATE_METRICS_SNAPSHOT_ASYNCHRONOUSLY_F19FE4E3
= "PrometheusReporter failed to update metrics snapshot asynchronously";
Review Comment:
Adds the asynchronous snapshot failure message to the i18n catalog so
updater errors use the project localization mechanism.
##########
iotdb-core/metrics/interface/src/main/i18n/zh/org/apache/iotdb/metrics/i18n/MetricsMessages.java:
##########
@@ -124,5 +124,6 @@ private MetricsMessages() {}
public static final String
LOG_IOTDBSESSIONREPORTER_START_WRITE_ARG_ARG_E79CDDAE = "IoTDBSessionReporter
启动，写入 {}:{}";
public static final String
LOG_PROMETHEUSREPORTER_STARTED_USE_PORT_ARG_A688FFC8 = "PrometheusReporter
已启动，使用端口 {}";
public static final String
LOG_DETECTED_ERROR_TAKING_METRIC_TIMER_SNAPSHOT_WILL_DISCARD_METRIC_B7154169 =
"获取 metric timer 快照时检测到错误，将丢弃该 metric";
+ public static final String
LOG_PROMETHEUSREPORTER_FAILED_TO_UPDATE_METRICS_SNAPSHOT_ASYNCHRONOUSLY_F19FE4E3
= "PrometheusReporter 异步更新监控项快照失败";
Review Comment:
Keeps the Chinese i18n catalog in key parity with the English catalog for
the new updater failure message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
