jt2594838 commented on code in PR #18562:
URL: https://github.com/apache/iotdb/pull/18562#discussion_r3912302563
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/metric/MetricService.java:
##########
@@ -74,7 +76,18 @@ protected void loadReporter() {
hasJmxReporter = true;
break;
case PROMETHEUS:
- reporter = new PrometheusReporter(metricManager);
+ if (METRIC_CONFIG.isPrometheusReporterAsyncUpdate()) {
+ // Defer pool creation until start so duplicate reporters rejected
below do not
Review Comment:
Caideyipi P3 fixed: pool creation is now deferred into the reporter start
lifecycle. If duplicate PROMETHEUS entries are rejected by CompositeReporter,
no IoTDB thread pool has been created or registered for the discarded reporter,
so thread-pool gauges continue to describe the active updater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
