HTHou commented on PR #18611: URL: https://github.com/apache/iotdb/pull/18611#issuecomment-5598140810
The added MOMENT MIT text matches upstream. I also checked the other AINode code and packaging paths against the current base (`25ab7941ce`). There are a few related follow-ups; these are pre-existing issues, not regressions introduced by this PR. 1. **Carry the MOMENT notice into the AINode binary distribution.** [ainode.xml](https://github.com/apache/iotdb/blob/25ab7941cebe6e14f396b5541cdd9daefae0f151/iotdb-core/ainode/ainode.xml#L36) copies `LICENSE-binary` and `NOTICE-binary`, and the distribution's [common-files.xml](https://github.com/apache/iotdb/blob/25ab7941cebe6e14f396b5541cdd9daefae0f151/distribution/src/assembly/common-files.xml#L37) does the same. Neither includes the root `LICENSE` updated here, and the binary notice files / `licenses/` have no MOMENT attribution. This change fixes the source-release path, but the corresponding notice also needs to reach the AINode binary package. This finding is based on the packaging configuration; I have not rebuilt the final AINode binary. 2. **GLIDE attribution in Sundial.** [flow_loss.py:92](https://github.com/apache/iotdb/blob/25ab7941cebe6e14f396b5541cdd9daefae0f151/iotdb-core/ainode/iotdb/ainode/core/model/sundial/flow_loss.py#L92) contains `timestep_embedding()` and explicitly links to GLIDE. Its implementation matches upstream after normalizing the variable/module names. The root license/notice files and `licenses/` omit GLIDE's `Copyright (c) 2021 OpenAI` and [MIT license](https://github.com/openai/glide-text2im/blob/main/LICENSE). This is another instance of the same kind of omission as MOMENT. 3. **Chronos attribution.** The root `LICENSE` identifies the adapted Chronos code, but the Amazon notice is absent from our notice files and the adapted source headers. Upstream has a [NOTICE](https://github.com/amazon-science/chronos-forecasting/blob/main/NOTICE) containing `Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.` The applicable attribution should be retained. 4. **uni2ts / Moirai2 copyright.** Our [RMSNorm](https://github.com/apache/iotdb/blob/25ab7941cebe6e14f396b5541cdd9daefae0f151/iotdb-core/ainode/iotdb/ainode/core/model/moirai2/module/norm.py#L26) has the same AST as [upstream](https://github.com/SalesforceAIResearch/uni2ts/blob/main/src/uni2ts/module/norm.py), whose header contains `Copyright (c) 2024, Salesforce, Inc.` That attribution is missing from our file and root license/notice files. The applicable original copyright headers should be preserved alongside our modification notices. 5. **Separate provenance check for DiT-derived code.** [FinalLayer](https://github.com/apache/iotdb/blob/25ab7941cebe6e14f396b5541cdd9daefae0f151/iotdb-core/ainode/iotdb/ainode/core/model/sundial/flow_loss.py#L150) explicitly says it is adopted from DiT and follows the corresponding implementation. [DiT's license](https://github.com/facebookresearch/DiT/blob/main/LICENSE.txt) is CC-BY-NC-4.0. Please verify the actual source revision and permission chain; Sundial's own Apache-2.0 label alone does not establish a compatible grant for this upstream portion. I have not established whether an additional grant exists, so this is a provenance/permission question rather than a confirmed absence of permission. Adding attribution alone would not resolve an incompatible license. For the Apache-2.0 components above, the issue is preserving the applicable copyright/NOTICE information, not duplicating the generic Apache license text. These follow-ups could be handled here or in separate changes, with the source and binary release contents checked afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
