CRZbulabula commented on PR #18611:
URL: https://github.com/apache/iotdb/pull/18611#issuecomment-5618358749
@HTHou Thank you for the detailed review and for identifying these
pre-existing follow-ups. I split the additional work into two focused PRs:
- #18620 addresses items 1-4:
- packages the MOMENT copyright and full MIT license in the AINode binary
distribution;
- adds the GLIDE copyright and full MIT license to the source and AINode
binary distributions;
- carries the Amazon NOTICE into the root and AINode-specific NOTICE files
and restores the upstream Chronos copyright/SPDX headers;
- restores the Salesforce copyright header for the adapted uni2ts/Moirai2
code; and
- introduces AINode-specific assembly metadata so these notices and
license files are included by both AINode packaging paths without affecting
unrelated binary distributions. The module and final AINode ZIP layouts were
also exercised with fixture payloads.
- #18616 addresses item 5 separately. It removes the implementation
identified as DiT-derived and replaces the conditional residual/output head
with an independently written PyTorch implementation based on the required
tensor and checkpoint contract. Existing checkpoint parameter paths and tensor
shapes are preserved, strict state-dict loading is tested, and a random-weight
comparison produced identical outputs. Focused behavior tests and the full CI
matrix pass on that PR.
This keeps #18611 scoped to the original MOMENT source-release omission
while the two follow-up PRs cover the broader source provenance and AINode
binary-packaging findings. Please take a look when convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]