jt2594838 commented on code in PR #18606:
URL: https://github.com/apache/iotdb/pull/18606#discussion_r3977848270
##########
iotdb-core/datanode/src/main/i18n/en/org/apache/iotdb/db/i18n/DataNodeMiscMessages.java:
##########
@@ -603,6 +603,10 @@ private DataNodeMiscMessages() {}
public static final String INPUT_DOUBLE_INFINITY = "The input double value
is Infinity";
public static final String BOOLEAN_PARSE_ERROR =
"The BOOLEAN should be true/TRUE, false/FALSE or 0/1";
+ public static final String DATA_TYPE_NOT_CONSISTENT_FMT =
+ "data type is not consistent, input %s, registered %s";
+ public static final String DATA_TYPE_NOT_CONSISTENT_WITH_CAUSE_FMT =
+ "data type is not consistent, input %s, registered %s because %s";
Review Comment:
Fixed in
[5eb7694245c](https://github.com/apache/iotdb/commit/5eb7694245c85771eccebdfcf68a0bfb1123a3f9).
The two newly introduced inconsistent-type messages now use the generated
EXCEPTION_<normalized text>_<hash> names in both locale files, with their
TypeServices call sites updated together. The existing unrelated
UNSUPPORTED_DATA_TYPE_FMT key is retained. English and Chinese source reactor
builds pass.
##########
iotdb-core/datanode/src/main/i18n/en/org/apache/iotdb/db/i18n/DataNodePipeMessages.java:
##########
@@ -1541,6 +1541,12 @@ public final class DataNodePipeMessages {
public static final String FAILED_TO_UNBIND_FROM_PIPE_TSFILE_TO =
"Failed to unbind from pipe tsfile to tablets metrics, pipe map is not
empty, pipe: {}";
+ //
---------------------------------------------------------------------------
+ // pipe – PipeRow
+ //
---------------------------------------------------------------------------
+ public static final String UNSUPPORTED_DATA_TYPE_FOR_COLUMN_FMT =
+ "unsupported data type %s for column %s";
Review Comment:
Fixed in
[5eb7694245c](https://github.com/apache/iotdb/commit/5eb7694245c85771eccebdfcf68a0bfb1123a3f9):
the key is now EXCEPTION_UNSUPPORTED_DATA_TYPE_ARG_FOR_COLUMN_ARG_4C4CCA6D in
both locale files, and both pipe row-reading call sites use it. The message
placeholders are preserved; English and Chinese source reactor builds pass.
##########
iotdb-core/datanode/src/main/i18n/en/org/apache/iotdb/db/i18n/DataNodeQueryMessages.java:
##########
@@ -528,6 +528,18 @@ public final class DataNodeQueryMessages {
"TIMESTAMP does not support REGEXP/NOT REGEXP";
public static final String GROUPBYTIME_FILTER_CANNOT_EXIST_IN_VALUE_FILTER =
"GroupByTime filter cannot exist in value filter.";
+ public static final String VALUE_CANNOT_BE_CAST_TO_DATA_TYPE_FMT =
+ "\"%s\" cannot be cast to [%s]";
+ public static final String UNSUPPORTED_DATA_TYPE_FMT =
+ "Unsupported data type %s";
Review Comment:
Fixed in
[5eb7694245c](https://github.com/apache/iotdb/commit/5eb7694245c85771eccebdfcf68a0bfb1123a3f9).
All newly added keys in this block now follow the generated exception-message
naming convention in both locales, including the cast, unsupported type,
MaxBy/MinBy, equal/variation event and TIMESTAMP IN-list messages. The
associated aggregation, predicate-conversion and TypeServices call sites and
message assertions were updated together. English and Chinese source reactor
builds pass.
##########
iotdb-core/datanode/src/main/i18n/en/org/apache/iotdb/db/i18n/DataNodeQueryMessages.java:
##########
@@ -1020,6 +1032,8 @@ public final class DataNodeQueryMessages {
"Unexpected expression: ";
public static final String FAILED_TO_FETCH_SUBQUERY_RESULT =
"Failed to Fetch Subquery Result.";
+ public static final String UNSUPPORTED_SCALAR_SUBQUERY_RESULT_DATA_TYPE_FMT =
+ "Unsupported data type for scalar subquery result: %s";
Review Comment:
Fixed in
[5eb7694245c](https://github.com/apache/iotdb/commit/5eb7694245c85771eccebdfcf68a0bfb1123a3f9):
both locale files and the scalar-subquery conversion call site now use
EXCEPTION_UNSUPPORTED_DATA_TYPE_FOR_SCALAR_SUBQUERY_RESULT_ARG_D58CBB00.
English and Chinese source reactor builds pass.
##########
iotdb-core/datanode/src/main/i18n/en/org/apache/iotdb/db/i18n/DataNodeQueryMessages.java:
##########
@@ -1393,6 +1407,8 @@ public final class DataNodeQueryMessages {
"Error occurred during getting UDF access strategy";
public static final String TRANSFORMUTILS_SHOULD_NOT_BE_INSTANTIATED =
"TransformUtils should not be instantiated.";
+ public static final String INVALID_DATA_TYPE_FOR_STATE_WINDOW_STRATEGY =
+ "The data type of the state window strategy is not valid.";
Review Comment:
Fixed in
[5eb7694245c](https://github.com/apache/iotdb/commit/5eb7694245c85771eccebdfcf68a0bfb1123a3f9):
both locale files and the state-window strategy call site now use
EXCEPTION_THE_DATA_TYPE_OF_THE_STATE_WINDOW_STRATEGY_IS_NOT_VALID_61F4E273.
English and Chinese source reactor builds pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]