jt2594838 commented on code in PR #18606:
URL: https://github.com/apache/iotdb/pull/18606#discussion_r4023489570


##########
iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/aggregation/VarianceAccumulator.java:
##########
@@ -52,37 +55,31 @@ public enum VarianceType {
 
   public VarianceAccumulator(TSDataType seriesDataType, VarianceType 
varianceType) {
     this.seriesDataType = seriesDataType;
+    this.doubleValueConverter =
+        TypeServices.NUMERIC_BATCH_READER_SERVICE

Review Comment:
   Use the native numeric batch reader for tree variance, retaining the 
existing recurrence callback and logical row order rather than changing the 
numerical algorithm. NumericMomentBatchTest covers moments/variance across 
tree, table and grouped implementations, including masked/null inputs. This 
candidate was retained after mixed-type and fixed-DOUBLE measurements; related 
candidates with measured regressions were restored.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to