CRZbulabula commented on code in PR #18696:
URL: https://github.com/apache/iotdb/pull/18696#discussion_r4080045007


##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -1341,17 +1364,35 @@ public TSStatus reconstructRegion(TReconstructRegionReq 
req) {
           return status;
         }
         procedures.add(new ReconstructRegionProcedure(regionId, 
targetDataNode, coordinator));

Review Comment:
   This comment applies to the superseded partial-submission design. The final 
contract now rejects the entire RECONSTRUCT / MIGRATE / EXTEND / REMOVE request 
if any ID or per-region validation fails, and submits zero procedures in that 
case. Commit 6ed6c446d9 validates all requested regions before submitting any 
procedure; ProcedureManagerRegionOperationTest explicitly verifies zero 
submissions when a later region is invalid. Continuing and submitting valid 
regions would violate this contract, so the early return is intentional. The 
CLI receives the operation-specific error through the existing exception path, 
without SQLWarning or a partial-success summary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to