Copilot commented on code in PR #18696:
URL: https://github.com/apache/iotdb/pull/18696#discussion_r4079377759


##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -1341,17 +1364,35 @@ public TSStatus reconstructRegion(TReconstructRegionReq 
req) {
           return status;
         }
         procedures.add(new ReconstructRegionProcedure(regionId, 
targetDataNode, coordinator));

Review Comment:
   Returning here aborts the whole request as soon as one existing region fails 
validation. Any previously validated regions remain in `procedures` but are 
never submitted, and the response loses the total/per-region summary this 
change adds. Record this status as a failed substatus and continue so valid 
regions are submitted after the loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to