Caideyipi commented on PR #19004:
URL: https://github.com/apache/iotdb/pull/19004#issuecomment-6406545580

   <!-- codex-self-review-pr-19004 -->
   Self-review passed after fixing one confirmed coverage regression in 
815426be9ade2a1ee92ae3cc0e7e1d4fc458e0e6. Reviewed the complete diff and the 
related TTL write/read paths, cache updates, and test environment. No remaining 
actionable findings.
   
   - **[P2] Keep the UNSET TTL probe outside the enlarged TTL** — 
[IoTDBTtlIT.java:121](https://github.com/apache/iotdb/blob/3835538c371f6cf9810119cd5302ef52755cd7f6/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBTtlIT.java#L121)
 increases TTL to `5000000`, but the probe at [line 
156](https://github.com/apache/iotdb/blob/3835538c371f6cf9810119cd5302ef52755cd7f6/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBTtlIT.java#L156)
 was still only about 30 seconds old. An ineffective `UNSET TTL` could 
therefore pass the `>= 200` assertion. Fixed the probe age to `8000000` ms. 
Also strengthened the existing wildcard-unset checks at [lines 257 and 
263](https://github.com/apache/iotdb/blob/815426be9ade2a1ee92ae3cc0e7e1d4fc458e0e6/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBTtlIT.java#L257)
 with `80000000` ms probes, outside their `50000000` ms TTL.
   - Removed the two fixed sleeps after `UNSET TTL`: successful execution 
already waits for the procedure to update all DataNode TTL caches. The enlarged 
live-data windows remain unchanged, with minimum headroom of about 66 minutes.
   
   Verification for the fixed source:
   
   - **PASS:** `mvn spotless:apply -P with-integration-tests -pl 
integration-test -o`; integration-test main and test compilation with JDK 17.
   - **PASS, remote:** Apache IoTDB, Cluster1 settings (1 ConfigNode + 3 
DataNodes), JUnit runner: `IoTDBTtlIT`, 1 test / 0 failures, 8.362 s including 
cluster lifecycle.
   - **PASS, remote slow-execution simulation:** a temporary copy of the same 
IT with its sampled `now` shifted back one hour, 1 test / 0 failures, 9.296 s. 
This validates one hour of additional timestamp aging without adding a real 
sleep or changing committed code.
   - **PASS, GitHub CI:** 
[ZH-Locale-Compile](https://github.com/apache/iotdb/actions/runs/40256385266) 
and [Dependency 
Check](https://github.com/apache/iotdb/actions/runs/40256385247) on the new 
head.
   - **FAILED setup attempts:** stale local extension artifacts, Windows 
commit-memory exhaustion, and initially missing repository JVM module-open 
flags in the remote launcher. These attempts did not reach TTL assertions; both 
corrected remote runs above passed. Further local tests were skipped as 
requested.
   - **IN PROGRESS:** [new-head GitHub Cluster IT - 
1C3D](https://github.com/apache/iotdb/actions/runs/40256385268), alongside the 
other automatically triggered workflows. These are not counted as passes.
   - **NOT RUN locally:** clean full-reactor builds and the full IT suite. 
Sonar/Codecov is skipped by GitHub CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to